[pkg-bacula-devel] [Git][bacula-team/bacula][master] 2 commits: Revert "use UTF8 encoding for new postgresql databases"

[Carsten Leonhardt]

Hi Sven,

Sven Hartge <sven at svenhartge.de> writes:

> On 25.08.25 09:03, Sven Hartge (@hartge) wrote:
>
>>     Revert "use UTF8 encoding for new postgresql databases"
>>     This reverts commit cc1a842fc085dc21b12fd9affbc226dd750233fe.
>>     The documentation (and source code) for Bacula 15.0.x *require*
>> the
>>     database to be in SQL_ASCII mode.
>
> Line 225++ of src/cats/postgresql.c
>
>    } else {
>       ret = bstrcmp(row[0], "SQL_ASCII");
>
>       if (ret) {
>          /* If we are in SQL_ASCII, we can force the client_encoding
>          to SQL_ASCII too */
>          mdb->sql_query("SET client_encoding TO 'SQL_ASCII'");
>
>       } else {
>          /* Something is wrong with database encoding */
>          Mmsg(mdb->errmsg,
>               _("Encoding error for database \"%s\". Wanted SQL_ASCII,
>               got %s\n"),
>               mdb->get_db_name(), row[0]);
>          return M_WARNING;
>       }
>
> The code is clear: be in SQL_ASCII mode, or else ...
>
> This warrants a quick new upload as the current packages in Sid create
> an unsupported database.

Hm, good catch.

as Salsa runners seem to be slow at the moment, I've uploaded the
current state to debusine:

https://debusine.debian.net/debian/developers/work-request/148419/

Piuparts there is broken, though:

https://salsa.debian.org/freexian-team/debusine/-/issues/952

 - Carsten