[pymvpa] tiny suggestion for SOM (10 second change)

Ike Hall ike.hall at gmail.com
Sun Mar 10 22:47:01 UTC 2013

It would appear that the SimpleSOMMapper class performs the initialization
of it's Kohonen layer in the SimpleSOMMapper._train method.  As the
.train() method calls ._pretrain, ._train, and ._posttrain in order, I
submit that it would be preferable to move the initialization phase to
._pretrain.  With this change, if one wants to subclass the SimpleSOMMapper
to use some other initialization, they only need to override ._pretrain
rather than _train.

--Ike Hall
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-exppsy-pymvpa/attachments/20130310/b7fcd14e/attachment.html>

More information about the Pkg-ExpPsy-PyMVPA mailing list