[pkg-go] Bug#1066219: golang-github-linuxkit-virtsock: FTBFS: src/github.com/linuxkit/virtsock/pkg/hvsock/hvsock_linux.go:33:12: error: implicit declaration of function ‘accept4’; did you mean ‘accept’? [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: golang-github-linuxkit-virtsock
Version: 0.0~git20170720.0.0416e3d-1.1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
>  debian/rules build
> dh build --buildsystem=golang --with=golang
>    dh_update_autotools_config -O--buildsystem=golang
>    dh_autoreconf -O--buildsystem=golang
>    dh_auto_configure -O--buildsystem=golang
>    dh_auto_build -O--buildsystem=golang
> 	cd obj-x86_64-linux-gnu && go install -trimpath -v -p 8 github.com/linuxkit/virtsock/cmd/sock_stress github.com/linuxkit/virtsock/cmd/vsudd github.com/linuxkit/virtsock/pkg/hvsock github.com/linuxkit/virtsock/pkg/vsock
> internal/coverage/rtcov
> internal/goos
> internal/godebugs
> internal/unsafeheader
> internal/goexperiment
> internal/goarch
> internal/cpu
> runtime/internal/atomic
> runtime/internal/syscall
> internal/race
> internal/chacha8rand
> internal/abi
> runtime/internal/math
> runtime/internal/sys
> sync/atomic
> math/bits
> unicode/utf8
> internal/itoa
> unicode
> encoding
> internal/bytealg
> cmp
> internal/nettrace
> log/internal
> slices
> math
> runtime
> internal/reflectlite
> sync
> internal/testlog
> internal/singleflight
> internal/bisect
> runtime/cgo
> internal/godebug
> errors
> sort
> internal/oserror
> internal/safefilepath
> io
> strconv
> path
> syscall
> vendor/golang.org/x/net/dns/dnsmessage
> internal/intern
> math/rand
> hash
> strings
> bytes
> reflect
> net/netip
> crypto
> internal/syscall/execenv
> internal/syscall/unix
> time
> internal/fmtsort
> encoding/binary
> context
> io/fs
> internal/poll
> crypto/md5
> golang.org/x/sys/unix
> os
> path/filepath
> fmt
> net
> log
> flag
> net/url
> github.com/linuxkit/virtsock/pkg/vsock
> log/syslog
> github.com/linuxkit/virtsock/pkg/hvsock
> # github.com/linuxkit/virtsock/pkg/hvsock
> src/github.com/linuxkit/virtsock/pkg/hvsock/hvsock_linux.go: In function ‘accept_hv’:
> src/github.com/linuxkit/virtsock/pkg/hvsock/hvsock_linux.go:33:12: error: implicit declaration of function ‘accept4’; did you mean ‘accept’? [-Werror=implicit-function-declaration]
>    33 |     return accept4(fd, (struct sockaddr *)sa_hv, sa_hv_len, 0);
>       |            ^~~~~~~
>       |            accept
> cc1: some warnings being treated as errors
> dh_auto_build: error: cd obj-x86_64-linux-gnu && go install -trimpath -v -p 8 github.com/linuxkit/virtsock/cmd/sock_stress github.com/linuxkit/virtsock/cmd/vsudd github.com/linuxkit/virtsock/pkg/hvsock github.com/linuxkit/virtsock/pkg/vsock returned exit code 1
> make: *** [debian/rules:4: build] Error 25


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/golang-github-linuxkit-virtsock_0.0~git20170720.0.0416e3d-1.1_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.