[sane-devel] treewide: use SANE_CURRENT_* macros consistently

Wolfram Sang wsa at kernel.org
Fri Jun 18 23:05:21 BST 2021


On Tue, Jun 08, 2021 at 09:57:43PM +0200, Wolfram Sang wrote:
> Hi,
> 
> I don't know how many developers also track pull requests on Gitlab. I
> have proposed one patch which affects 91 drivers, so I thought I
> advertise it here as well to collect reviews. It is this pull request:
> 
> https://gitlab.com/sane-project/backends/-/merge_requests/632
> 
> with this description:
> 
> Backends use a mixture of SANE_CURRENT_{MAJOR | MINOR} and V_{MAJOR |
> MINOR} with all kind of permutations. I was confused by this and one
> comment in pieusb.c tells me I was not alone. Some items in old
> changelogs suggest to use the SANE_CURRENT_ macros in backends, so let's
> switch to do that with the exception of net.c and dll.c. Done with:
> 
> $ find backend -name '*.[ch]' | xargs sed -i '/nearly every/ ! { s/<V_M/SANE_CURRENT_M/g }'
> $ git checkout backend/net.c backend/dll.c
> 
> And manually removing the comment from pieusb.c. Everything still builds
> fine.
> 
> Looking forward to comments!

To avoid bitrot, I'd like to merge it this weekend. So, if you have
comments or objections, now would be a good time ;)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/sane-devel/attachments/20210619/decd1685/attachment.sig>


More information about the sane-devel mailing list