[Debian-pan-maintainers] Bug#1087738: Incomplete patch

[Roland Mas]

Hi Gilles,

Thanks for the patch, it does help the compilation… but the testsuite 
seems to fail now:

Configuring test suite 'hkl-test' for hkl-0.1.0.2..
Warning: 'c-sources: ./../hkl/hkl-axis.c' is a relative path outside of the
source tree. This will not work when generating a tarball with 'sdist'.
Warning: 'c-sources: ./../hkl/hkl-geometry.c' is a relative path outside of
the source tree. This will not work when generating a tarball with 'sdist'.
Warning: 'c-sources: ./../hkl/hkl-interval.c' is a relative path outside of
the source tree. This will not work when generating a tarball with 'sdist'.
Warning: 'c-sources: ./../hkl/hkl-lattice.c' is a relative path outside 
of the
source tree. This will not work when generating a tarball with 'sdist'.
Warning: 'c-sources: ./../hkl/hkl-macros.c' is a relative path outside 
of the
source tree. This will not work when generating a tarball with 'sdist'.
Warning: 'c-sources: ./../hkl/hkl-matrix.c' is a relative path outside 
of the
source tree. This will not work when generating a tarball with 'sdist'.
Warning: 'c-sources: ./../hkl/hkl-parameter.c' is a relative path outside of
the source tree. This will not work when generating a tarball with 'sdist'.
Warning: 'c-sources: ./../hkl/hkl-quaternion.c' is a relative path 
outside of
the source tree. This will not work when generating a tarball with 'sdist'.
Warning: 'c-sources: ./../hkl/hkl-sample.c' is a relative path outside 
of the
source tree. This will not work when generating a tarball with 'sdist'.
Warning: 'c-sources: ./../hkl/hkl-source.c' is a relative path outside 
of the
source tree. This will not work when generating a tarball with 'sdist'.
Warning: 'c-sources: ./../hkl/hkl-unit.c' is a relative path outside of the
source tree. This will not work when generating a tarball with 'sdist'.
Warning: 'c-sources: ./../hkl/hkl-vector.c' is a relative path outside 
of the
source tree. This will not work when generating a tarball with 'sdist'.
Preprocessing test suite 'hkl-test' for hkl-0.1.0.2..
Building test suite 'hkl-test' for hkl-0.1.0.2..
[1 of 3] Compiling Paths_hkl        ( 
/build/hkl-5.1.2/binoculars-ng/dist-newstyle/build/x86_64-linux/ghc-9.6.6/hkl-0.1.0.2/t/hkl-test/build/hkl-test/autogen/Paths_hkl.hs, 
/build/hkl-5.1.2/binoculars-ng/dist-newstyle/build/x86_64-linux/ghc-9.6.6/hkl-0.1.0.2/t/hkl-test/build/hkl-test/hkl-test-tmp/Paths_hkl.o, 
/build/hkl-5.1.2/binoculars-ng/dist-newstyle/build/x86_64-linux/ghc-9.6.6/hkl-0.1.0.2/t/hkl-test/build/hkl-test/hkl-test-tmp/Paths_hkl.dyn_o 
)
[2 of 3] Compiling BinocularsSpec   ( test/BinocularsSpec.hs, 
/build/hkl-5.1.2/binoculars-ng/dist-newstyle/build/x86_64-linux/ghc-9.6.6/hkl-0.1.0.2/t/hkl-test/build/hkl-test/hkl-test-tmp/BinocularsSpec.o 
)

test/BinocularsSpec.hs:12:1: warning: [-Wunused-imports]
     The import of `Data.Aeson' is redundant
       except perhaps to import instances from `Data.Aeson'
     To import instances alone, use: import Data.Aeson()
    |
12 | import           Data.Aeson                         (Result (..), 
fromJSON,
    | 
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...

test/BinocularsSpec.hs:16:1: warning: [-Wunused-imports]
     The import of `Data.HashMap.Lazy' is redundant
       except perhaps to import instances from `Data.HashMap.Lazy'
     To import instances alone, use: import Data.HashMap.Lazy()
    |
16 | import           Data.HashMap.Lazy (fromList)
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

test/BinocularsSpec.hs:19:1: warning: [-Wunused-imports]
     The import of `Numeric.Units.Dimensional.Prelude' is redundant
       except perhaps to import instances from 
`Numeric.Units.Dimensional.Prelude'
     To import instances alone, use: import 
Numeric.Units.Dimensional.Prelude()
    |
19 | import           Numeric.Units.Dimensional.Prelude  (meter, radian, 
(*~))
    | 
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

test/BinocularsSpec.hs:20:1: warning: [-Wunused-imports]
     The import of `Path' is redundant
       except perhaps to import instances from `Path'
     To import instances alone, use: import Path()
    |
20 | import           Path (mkAbsDir)
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

test/BinocularsSpec.hs:25:1: warning: [-Wunused-imports]
     The import of `Hkl.Binoculars.Config.Common' is redundant
       except perhaps to import instances from 
`Hkl.Binoculars.Config.Common'
     To import instances alone, use: import Hkl.Binoculars.Config.Common()
    |
25 | import           Hkl.Binoculars.Config.Common
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

test/BinocularsSpec.hs:26:1: warning: [-Wunused-imports]
     The import of `Hkl.Binoculars.Config.Sample' is redundant
       except perhaps to import instances from 
`Hkl.Binoculars.Config.Sample'
     To import instances alone, use: import Hkl.Binoculars.Config.Sample()
    |
26 | import           Hkl.Binoculars.Config.Sample
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

test/BinocularsSpec.hs:27:1: warning: [-Wunused-imports]
     The import of `Hkl.Binoculars.Projections.Hkl' is redundant
       except perhaps to import instances from 
`Hkl.Binoculars.Projections.Hkl'
     To import instances alone, use: import Hkl.Binoculars.Projections.Hkl()
    |
27 | import           Hkl.Binoculars.Projections.Hkl
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

test/BinocularsSpec.hs:29:1: warning: [-Wunused-imports]
     The import of `Hkl.DataSource' is redundant
       except perhaps to import instances from `Hkl.DataSource'
     To import instances alone, use: import Hkl.DataSource()
    |
29 | import           Hkl.DataSource
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[3 of 3] Compiling Main             ( test/Spec.hs, 
/build/hkl-5.1.2/binoculars-ng/dist-newstyle/build/x86_64-linux/ghc-9.6.6/hkl-0.1.0.2/t/hkl-test/build/hkl-test/hkl-test-tmp/Main.o 
)
[4 of 4] Linking 
/build/hkl-5.1.2/binoculars-ng/dist-newstyle/build/x86_64-linux/ghc-9.6.6/hkl-0.1.0.2/t/hkl-test/build/hkl-test/hkl-test
ln -s -f $(/usr/bin/cabal --config-file=empty-config-file list-bin 
hkl-test) hkl-test
FAIL: hkl-test
=============================================
    hkl 5.1.2: binoculars-ng/test-suite.log
=============================================

# TOTAL: 1
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: hkl-test
==============


Binoculars
   Limits
     quickcheck Limits2 [v]
       +++ OK, passed 100 tests.
     quickcheck Limits3 [v]
       +++ OK, passed 100 tests.
   ConfigRange
     parse a range [v]
     parse a range [v]
     parse a range [v]
     parse a range [v]
     parse a range [v]
     parse a range [v]
     parse a range [v]
     quickcheck [v]
       +++ OK, passed 100 tests.
   read and parse binoculars configuration
     deprecated inputype [x]

Failures:

   ./test/BinocularsSpec.hs:72:5:
   1) Binoculars, read and parse binoculars configuration, deprecated 
inputype
        uncaught exception: IOException of type InvalidArgument
        data/test/config_sixs_ruche_parsing.ini: hGetContents: invalid 
argument (cannot decode byte sequence starting from 194)

   To rerun use: --match "/Binoculars/read and parse binoculars 
configuration/deprecated inputype/" --seed 639750404

Randomized with seed 639750404

Finished in 0.0084 seconds
11 examples, 1 failure
FAIL hkl-test (exit status: 1)

============================================================================
Testsuite summary for hkl 5.1.2
============================================================================
# TOTAL: 1
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See binoculars-ng/test-suite.log
Please report to picca at synchrotron-soleil.fr

(Tested in a cowbuilder chroot on amd64; I pushed the updated code to 
salsa for reference and collaboration)

Roland.